Repository navigation
fix: execute all DEV deployment checks over SSH stdin - #787
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DEV deploy мог завершиться с exit 0 до последних checks:
docker compose execчитал остаток переданного на Bash stdin скрипта. На первом rollout #784 migration connection и новые containers прошли, но source/nginx/HTTP/Celery checks в конце скрипта не выполнились; лог заканчивается после image ID checks.Теперь транспорт передаёт весь script единым Bash-блоком с
</dev/null. Bash сначала разбирает блок целиком; дочерние процессы получают EOF, а явные heredoc payload/Python сохраняются. Fixed SSH argv, host pinning и credential isolation не меняются.Scope: только transport, его regression tests и runbook (3 files). Application code, models, migrations, runtime credentials и PROD не меняются.
Проверки:
false.node --checkобоих файлов,git diff --check— PASS.Base:
1734ef7362e1640a4ff451e4e4ff184cdf249fb2.Head:
09c76fba9c912df75d47584a248840ecc566bb82.Исправление необходимо для завершения уже разрешённой DEV activation migration-role. PROD release/deploy не выполняется.
DEV activation completed — 18.10.2026
5bc06ed99db69be20c5282754a03eb8f3f7928db, imageprocollab-dev-api:5bc06ed99db69be20c5282754a03eb8f3f7928db-096712031353.procollab_api: actual preflight PASS, pending=0, migrate + обычный runtime migrate-check PASS. Новых unapplied migrations в этом rollout не было; искусственный live DDL не создавался.